Skip to content

Commit

Permalink
Upgraded gradle version
Browse files Browse the repository at this point in the history
  • Loading branch information
sushant-varanasi committed Aug 21, 2021
1 parent 384351b commit 0b5d271
Show file tree
Hide file tree
Showing 9 changed files with 55 additions and 34 deletions.
18 changes: 1 addition & 17 deletions .idea/compiler.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions .idea/jarRepositories.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 22 additions & 3 deletions .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions .idea/modules.xml

This file was deleted.

1 change: 1 addition & 0 deletions .idea/runConfigurations.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ android {
variant.outputs.all { output ->
def project = "facelogin"
def SEP = "."
def buildType = variant.variantData.variantConfiguration.buildType.name
def buildType = variant.buildType.name
def version = variant.versionName

def newApkName = project + SEP + buildType + SEP + version + ".apk"
outputFileName = new File(output.outputFile.parent, newApkName)
outputFileName = new File("./../../../../../build/", newApkName)
}
}

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ buildscript {
}
dependencies {

classpath 'com.android.tools.build:gradle:3.0.1'
classpath 'com.android.tools.build:gradle:4.1.0'

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
Expand Down
3 changes: 1 addition & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#Tue Dec 05 13:11:45 EST 2017
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip

1 comment on commit 0b5d271

@JackMostow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"outputFileName = new File("./../../../../../build/", newApkName)" makes a strong assumption about folder structure. At minimum document the assumed structure.
Does upgrading the gradle version also fix the RoboFeel python issue?

Please sign in to comment.