refactor: further remove reference to faction camp (cataclysmbnteam#5147

)

* refactor: further erase reference to faction camp

* docs: remove obsolete flags

* refactor: remove unused script

doc/src/content/docs/en/mod/json/guides/map/mapgen.md

@@ -750,5 +750,4 @@ Not covered in this document:
 - Advanced terrain tricks for complex floor options.
 - traps, terrain and you.
 - update_mapgen (NPC and player triggered map updates).
-- faction camp expansion maps.
 - field emitting furniture.

doc/src/content/docs/en/mod/json/reference/creatures/npcs.md

@@ -600,9 +600,6 @@ effects should be arranged in a list and are processed in the order listed.
 | -------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | `assign_guard`                         | Makes the NPC into a guard. If allied and at a camp, they will be assigned to that camp.                                                                        |
 | `stop_guard`                           | Releases the NPC from their guard duty (also see `assign_guard`). Friendly NPCs will return to following.                                                       |
-| `start_camp`                           | The NPC will start a faction camp with the player.                                                                                                              |
-| `recover_camp`                         | Makes the NPC the overseer of an existing camp that doesn't have an overseer.                                                                                   |
-| `remove_overseer`                      | Makes the NPC stop being an overseer, abandoning the faction camp.                                                                                              |
 | `wake_up`                              | Wakes up sleeping, but not sedated, NPCs.                                                                                                                       |
 | `reveal_stats`                         | Reveals the NPC's stats, based on the player's skill at assessing them.                                                                                         |
 | `end_conversation`                     | Ends the conversation and makes the NPC ignore you from now on.                                                                                                 |

doc/src/content/docs/en/mod/json/reference/json_flags.md

@@ -641,7 +641,6 @@ List of known flags, used in both `terrain.json` and `furniture.json`.
 - `autoclave_full` Check on the progress of the cycle, and collect sterile CBM once cycle is
   completed.
 - `bars` Take advantage of AMORPHOUS and slip through the bars.
-- `bulletin_board` Use this to arrange tasks for your faction camp.
 - `cardreader` Use the cardreader with a valid card, or attempt to hack.
 - `chainfence` Hop over the chain fence.
 - `controls_gate` Controls the attached gate.

src/faction.cpp

@@ -619,8 +619,7 @@ void faction_manager::display() const
     ui.mark_resize();
 
     enum class tab_mode : int {
-        TAB_MYFACTION = 0,
-        TAB_FOLLOWERS,
+        TAB_FOLLOWERS = 0,
         TAB_OTHERFACTIONS,
         NUM_TABS,
         FIRST_TAB = 0,
@@ -655,7 +654,6 @@ void faction_manager::display() const
         }
 
         const std::vector<std::pair<tab_mode, std::string>> tabs = {
-            { tab_mode::TAB_MYFACTION, _( "YOUR FACTION" ) },
             { tab_mode::TAB_FOLLOWERS, _( "YOUR FOLLOWERS" ) },
             { tab_mode::TAB_OTHERFACTIONS, _( "OTHER FACTIONS" ) },
         };
@@ -671,11 +669,6 @@ void faction_manager::display() const
         const size_t top_of_page = entries_per_page * ( selection / entries_per_page );
 
         switch( tab ) {
-            case tab_mode::TAB_MYFACTION: {
-                const std::string no_camp = _( "You have no camps" );
-                mvwprintz( w_missions, point( 31, 4 ), c_light_red, no_camp );
-            }
-            break;
             case tab_mode::TAB_FOLLOWERS: {
                 const std::string no_ally = _( "You have no followers" );
                 if( !followers.empty() ) {
@@ -760,8 +753,6 @@ void faction_manager::display() const
                 guy = followers[selection];
             }
             active_vec_size = followers.size();
-        } else if( tab == tab_mode::TAB_MYFACTION ) {
-            active_vec_size = 0;
         } else if( tab == tab_mode::TAB_OTHERFACTIONS ) {
             if( selection < valfac.size() ) {
                 cur_fac = valfac[selection];