Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for psr/container ^2.0 #19

Open
wants to merge 2 commits into
base: 2.2.x
Choose a base branch
from

Conversation

Nguimjeu
Copy link

@Nguimjeu Nguimjeu commented Jul 15, 2022

Fixes #18

- Add support for `psr/container`: `^2.0`
- See: Roave#18
composer.json Show resolved Hide resolved
@Ocramius Ocramius added this to the 2.2.0 milestone Jul 15, 2022
- Upgrade psr/container (1.1.2 => 2.0.2)
- Update function declaration for anonymous class in `ContainerFactoryTest.php`
- Run `composer update`
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @Nguimjeu

@Ocramius Ocramius self-assigned this Jul 20, 2022
@Ocramius
Copy link
Member

Ah, never mind, tests are all completely broken :D

Nope, need to rework this until it's green, sorry.

@Ocramius Ocramius self-requested a review July 20, 2022 10:25
@Ocramius Ocramius removed this from the 2.2.0 milestone Oct 31, 2022
@Ocramius
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roave/behat-psr11extension 2.1.0 requires psr/container ^1.0
3 participants