Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a feature test to demonstrate injection #1

Merged
merged 4 commits into from
Aug 14, 2017
Merged

Added a feature test to demonstrate injection #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
019d941
Added a feature test to demonstrate injection
asgrim Aug 9, 2017
e6cf013
Fixed Ciaran link
asgrim Aug 9, 2017
923a58f
Require at least Symfony DI 3.3 for tags
asgrim Aug 9, 2017
7944fc7
Remove composer.lock
asgrim Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"require": {
"php": "^7.1",
"behat/behat": "^3.3",
"psr/container": "^1.0"
"psr/container": "^1.0",
"symfony/dependency-injection": "^3.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to fix the tags instead, in the services.yml - I'll look at that as a separate change after this is merged though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, I'll create a separate issue for it

},
"require-dev": {
"zendframework/zend-servicemanager": "^3.3"
Expand Down
Loading