Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2023 members #188

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Added 2023 members #188

merged 6 commits into from
Dec 2, 2024

Conversation

GilMM27
Copy link

@GilMM27 GilMM27 commented Nov 27, 2024

No description provided.

@GilMM27 GilMM27 requested a review from Oscar-gg as a code owner November 27, 2024 02:54
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
roborregos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 6:07pm

@GilMM27 GilMM27 requested a review from IvanRomero03 November 27, 2024 02:55
src/data/members.json Outdated Show resolved Hide resolved
"role": "Software Development",
"subtitle": "",
"class": "2023",
"semesters": "8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix semesters

@IvanRomero03
Copy link
Member

ping on this pr, @GilMM27 hows the update going?

Copy link
Member

@IvanRomero03 IvanRomero03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if no more members to be added

@Oscar-gg
Copy link
Member

I think the following are pending:

  • Fix image dimensions (Amin Image)
  • Move inactive members to inactive section

@Oscar-gg
Copy link
Member

Oscar-gg commented Dec 2, 2024

Lgtm 🚀

@GilMM27 GilMM27 merged commit 197de17 into develop Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants