Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new boolean config twitter.exclude_replies #1991

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YorkOrz
Copy link

@YorkOrz YorkOrz commented Aug 24, 2022

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

Added new boolean config twitter.exclude_replies.
Moved LabelsBundle_zh_CN.properties to resources.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@YorkOrz YorkOrz changed the title Pull requests Added new boolean config twitter.exclude_replies Aug 24, 2022
@mingnel123
Copy link

Good

@soloturn
Copy link
Contributor

soloturn commented Oct 8, 2022

why the change in the chinese labels file?
https://github.com/RipMeApp/ripme/pull/1991/files#diff-8761092bc389fd60dd1900e28e88ddce0e4c830a3300522221188641e22e8b3d

mind making a pr here as well: https://github.com/ripmeapp2/ripme. merge rights is restricted here unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants