Avoid mixing up truckfiles when filename isn't unique.

[ohlidalp]

Fixes #3166

Problem1: When spawning an actor, the cache entry was always looked up via truckfile name, even if it was already known from the Selector UI. This potentially caused mixups.

Fix2: Use the entry provided by Selector UI.

Problem2: in many scenarios, the game selects an actor by truckfile name alone:

• savegames
• preselected truck in RoR.cfg
• preloaded trucks on terrain (.tobj)
• Multiplayer spawn notifications

Fix2: introduce an optional "Bundle-qualified" syntax, i.e. "mybundle.zip:myactor.truck" (in case of ZIP archive) or "mysubdir:myproject.truck" (in case of subdir) and use it in all the above cases. Because it's optional, it doesn't need a version bump in savegame format or RoRnet protocol. Note that 'bundle' is RoR jargon for a ZIP archive or directory under /mods.

Testing

Use the attached mods and spawn them using console commands:
dafsemiMixupTest_hangar.zip
dafsemiMixupTest_transred.zip

This uses just filename - it will spawn the first one in your 'mods.cache' JSON file.

as game.pushMessage(MSG_SIM_SPAWN_ACTOR_REQUESTED, { {'filename', 'dafsemiMixupTest.truck'}, {'position', game.getPersonPosition()}, {'rotation', quaternion(game.getPersonRotation(), vector3(0,1,0))} });

This uses explicit bundle name, so it will spawn the Transred variant.

as game.pushMessage(MSG_SIM_SPAWN_ACTOR_REQUESTED, { {'filename', 'dafsemiMixupTest_transred.zip:dafsemiMixupTest.truck'}, {'position', game.getPersonPosition()}, {'rotation', quaternion(game.getPersonRotation(), vector3(0,1,0))} });

This uses explicit bundle name and demonstrates case-insensitive lookup - it will spawn the Hangar variant.

as game.pushMessage(MSG_SIM_SPAWN_ACTOR_REQUESTED, { {'filename', 'DAFSEMIMIXUPTEST_HANGAR.ZIP:DAFSEMIMIXUPTEST.TRUCK'}, {'position', game.getPersonPosition()}, {'rotation', quaternion(game.getPersonRotation(), vector3(0,1,0))} });

[CuriousMike56]

Duplicate files spawn OK now, however trying to load a savegame with them always crashes.

[ohlidalp]

Indeed, the savegames only record the filename. Same goes for:

• preselected truck in RoR.cfg
• preloaded trucks on terrain (.tobj)
• AFAIK also RoRnet spawn notifications

I'll try the following solution: in any text field which expects filename, user can also put "mybundle.zip:myactor.truck". On Windows, : is already forbidden in filenames so this clearly indicates a special behavior - Linux doesn't have this rule but it probably should, so let's assume nobody puts colons in mod filenames.

[CuriousMike56]

Works nicely, though it's probably not a good idea for bundle names to be announced to other players:

Just another opportunity for someone to name the zip/subdir something vile.

[ohlidalp]

Very good point, I'll strip the names from the log messages.

EDIT: done.

[Zentro]

Works as intended.