Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinecam improvements #3010

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cinecam improvements #3010

wants to merge 3 commits into from

Conversation

ohlidalp
Copy link
Member

@ohlidalp ohlidalp commented Jan 28, 2023

Changes:

  • Cinecam mouse-look speed is faster overall and no longer depends on screen resolution.
  • Removed old input event CAMERA_LOOKBACK which first resets view to front and then toggles back view.
  • Added new input events CAMERA_LOOK_BACK, CAMERA_LOOK_LEFT and CAMERA_LOOK_RIGHT which first put you to angled look and only then reset back to front.

Notes:

  • CAMERA_LOOK_LEFT and CAMERA_LOOK_RIGHT have no default bindings because all other camera controls are on numpad and all keys there are taken: 5=reset, 8/4/6/2=rotate, 1=lookback, 9/3 = zoom in/out, 7=FOV. I'd like to make it SHIFT+NUMPAD4/6, but that would conflict with ROTATE_LEFT/RIGHT which don't have EXPL tag.

@danmackey
Copy link
Contributor

Could something be done to improve zooming in an out? I noticed that from the cinecam there is smooth, float based, FOV zooming in the dropdown menu. Something like that would be pretty nice to have in regular free cam.

ohlidalp added 2 commits March 8, 2024 04:17
The rotation speed no longer depends on rendering resolution.
The rotation is faster overall, horizontal rotation is a little faster than vertical rotation.
@ohlidalp
Copy link
Member Author

ohlidalp commented Mar 9, 2024

Dusting this off after a year.

@danmackey It's sort of a convention in games to give FOV values integral. We have multiple presets - I'll create another PR to address this:
* gfx_static_cam_fov_exp (float) ~ A "zoom factor" of static camera; Adjust by 'Ctrl+mouse wheel' or TopMenubar/Settings.
* gfx_fov_internal (int) ~ FOV of cinecam; Adjust by hotkeys
* gfx_fov_external (int) ~ FOV of exterior cameras (3rd person, free cam, freefixed cam), adjustable by hotkeys.

Notes by DannyWerewolf on Discord:

@ohlidalp
Copy link
Member Author

This is ready for testing again. Any smoothing will be dealt with in #3139

Renamed LOOKBACK to LOOK_BACK
Changed toggle order: instead of resetting to front view first and then toggling the direction, the direction is toggled immediatelly and only a second press resets view to front.

Note: LOOK_LEFT+LOOK_RIGHT have no default bindings because all numpad keys are taken.
@CuriousMike56
Copy link
Collaborator

The recently added "invert orbit camera" option doesn't appear to work correctly:

8mb.video-JrU-baNMRWEq.mp4

Mouse look speed is also slower with this enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants