Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support latest kit version #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpaquim
Copy link

@jpaquim jpaquim commented Mar 16, 2022

Update dependencies to latest version. The resulting package should be compatible with the latest SvelteKit version.

@jpaquim
Copy link
Author

jpaquim commented Mar 16, 2022

Fixes #28 from my tests. I was facing a few issues with pnpm's handling of the yooutils and other dependencies, needed to shamefully hoist those to work correctly.

@braebo
Copy link

braebo commented Mar 30, 2022

Thanks for this! Would love to be able to use this with svelte-kit. When I try to install your fork, I get this error when importing svelte-knobby:

> Build failed with 1 error:
node_modules/.pnpm/[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-9c153816.js:29537:10:
ERROR: [plugin: vite:dep-scan] Failed to resolve entry for package "svelte-knobby". The package may have incorrect main/module/exports specified in its package.json: Failed to resolve entry for package "svelte-knobby". The package may have incorrect main/module/exports specified in its package.json.

Should I fork your fork and build it first if I want to use it?

braebo added a commit to braebo/svelte-knobby that referenced this pull request Mar 30, 2022
@jpaquim
Copy link
Author

jpaquim commented Mar 30, 2022

Hey @fractalhq! Yes, I'm basically including my fork as a git submodule and building it locally before my svelte-kit builds. You can check out either https://github.com/jpaquim/svelte-webgl-fluid-simulation or https://github.com/jpaquim/svelte-webgpu for examples of usage.

I'd assume that when integrated upstream (this repo) this manual build process won't be necessary anymore, but there still may be some details I'm overlooking...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants