Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Tagnames for the user after comparing #76

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

amitjimiwal
Copy link

Copy link

vercel bot commented Jun 9, 2024

@amitjimiwal is attempting to deploy a commit to the rhyssullivan's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shiptalkers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 10:43am

@RhysSullivan
Copy link
Owner

Thanks for opening this PR! I deployed it so you can see it with prod data

https://shiptalkers-git-fork-amitjimiwal-tagline-rhyssullivans-projects.vercel.app/compare?github=ndavd&twitter=0xndavd

Looks like that may be incorrectly marked as perfectly balanced?

@RhysSullivan
Copy link
Owner

Indie hackers also might be good to swap out for "founder" if it's >100k followers I.e https://shiptalkers-git-fork-amitjimiwal-tagline-rhyssullivans-projects.vercel.app/compare?name=karpathy

@amitjimiwal
Copy link
Author

Yes , I just swapped it for founder if follower > 100k. I have added search param follower in api/og/compare route for reflecting changes in the image.

@RhysSullivan
Copy link
Owner

thanks, im finishing a major feature then i'll take a look

@amitjimiwal
Copy link
Author

amitjimiwal commented Jun 12, 2024

Hey @RhysSullivan , just updated the tags on the cofounders and other pages. Can you check it out ?.
Do lemme know the changes req.

@amitjimiwal
Copy link
Author

@RhysSullivan any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants