Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL -- Actual fixes #2720

Merged
merged 12 commits into from
Jan 15, 2025
Prev Previous commit
Next Next commit
Workaround old GCC on Windows builds
This is supported for GCC >= version 13

See GCC bug 85487:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85487
  • Loading branch information
henrygab committed Jan 15, 2025
commit 6613ff73343f87661c0a52aba17febf7f1ecd5c5
4 changes: 2 additions & 2 deletions armsrc/spiffs_check.c
Original file line number Diff line number Diff line change
@@ -540,7 +540,7 @@ static s32_t spiffs_page_consistency_check_i(spiffs *fs) {
uint32_t total_blocks = SPIFFS_PAGES_PER_BLOCK(fs) * block_count;
uint32_t total_blocks_plus_one_page = total_blocks + SPIFFS_PAGES_PER_BLOCK(fs);

#pragma region // check for overflow once, before looping
//#pragma region // check for overflow once, before looping
// this _should_ never happen, but prefer to see debug message / error
// rather than silently entering infinite loop.
if (block_count > ((spiffs_block_ix)(-1))) {
@@ -568,7 +568,7 @@ static s32_t spiffs_page_consistency_check_i(spiffs *fs) {
}
// RESULT: spiffs_page_ix can safely be used for loop index vs. each of
// block_count, total_blocks, and total_blocks_plus_one_page
#pragma endregion // check for overflow once, before looping
//#pragma endregion // check for overflow once, before looping


// for each range of pages fitting into work memory
Loading