Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds LinuxMint #506

Closed
wants to merge 2 commits into from
Closed

Adds LinuxMint #506

wants to merge 2 commits into from

Conversation

JJ
Copy link

@JJ JJ commented Dec 10, 2014

Adds LinuxMint, which is basically a copy of Ubuntu. Previously Mint yielded "Not supported OS" or suchlike. Thanks to @toblerone554 for hint.

@Tweaki
Copy link

Tweaki commented Dec 10, 2014

Can one of the admins verify this patch?

@ferki
Copy link
Member

ferki commented Dec 10, 2014

@JJ: thanks for the contribution! I believe there wouldn't be much obstacles to add LinuxMint support as it is really a Debian/Ubuntu clone AFAIK - and tackling the package management is definitely a good first step towards it!

I think we should look into and consider handling at least the following additional parts of the full story:

  • services management
  • adding Mint as Debian clone for hardware gathering, maybe?
  • possibly adding is_linuxmint function or similar
  • adding a LinuxMint VM image to build.rexify.org to be able to run automated functional tests

@JJ
Copy link
Author

JJ commented Dec 10, 2014

Could give it a try, of course, but first thing first. Should I start with the last and proceed upwards?

@ferki
Copy link
Member

ferki commented Dec 10, 2014

@JJ: feel free to proceed in any order you find comfortable :) For the VM image, you can find some guidelines in RexOps/rex-build#3. Should you have any questions, feel free to ask here or in our IRC channel!

ps.: I just noticed you used your clone's master branch with this pull request. Of course it's also a matter of taste and personal workflow preferences, but generally we recommend creating a feature branch, as that can make things easier. We can try to follow this as it is now. Also there are some contribution guidelines on the website you might be interested in.

@JJ
Copy link
Author

JJ commented Dec 10, 2014

Great, will do.

2014-12-10 19:00 GMT+01:00 Ferenc Erki [email protected]:

@JJ https://github.com/JJ: feel free to proceed in any order you find
comfortable :) For the VM image, you can find some guidelines in
RexOps/rex-build#3 RexOps/rex-build#3. Should
you have any questions, feel free to ask here or in our IRC channel!

ps.: I just noticed you used your clone's master branch with this pull
request. Of course it's also a matter of taste and personal workflow
preferences, but generally we recommend creating a feature branch, as that
can make things easier. We can try to follow this as it is now. Also there
are some contribution guidelines http://rexify.org/contribute on the
website you might be interested in.


Reply to this email directly or view it on GitHub
#506 (comment).

JJ

@ferki
Copy link
Member

ferki commented May 30, 2015

This issue looks like abandoned, but we decided to try to add Linux Mint support by recognizing it as an Ubuntu clone (which might be even easier to implement than writing hardware gathering and service/package management abstractions).

@ferki ferki added this to the 1.3.0 milestone May 30, 2015
@krimdomu krimdomu modified the milestones: 1.4.0, 1.3.0 May 30, 2015
ferki added a commit that referenced this pull request Jul 26, 2015
@ferki ferki assigned ferki and unassigned krimdomu Jul 26, 2015
ferki added a commit that referenced this pull request Sep 5, 2015
@ferki ferki closed this in 23047e7 Oct 30, 2015
@ferki
Copy link
Member

ferki commented Oct 30, 2015

@JJ: this has been solved via merging #745. Thanks for your help around realizing this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants