Account Id is now optional #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amir27111998
requested review from
MGB247 and
Rayyan98
and removed request for
MGB247
MGB247
reviewed
Aug 8, 2023
| } else { | ||
| const { region, accountId } = this.options.awsConfig; | ||
| if (!accountId) | ||
| this.getAwsAccountId(region).then((accountId) => { |
There was a problem hiding this comment.
use async/await and try/catch
There was a problem hiding this comment.
There is a reason not using async await here because we have to call its outer function in constructor? I don't know can constructor supports asynchronous calls
There was a problem hiding this comment.
Lets discuss this
A lot of functions rely on accountId and making this asynchronous would mean that those functions break if called before the accountId is set
MGB247
reviewed
Aug 8, 2023
Comment on lines
+112
to
+113
| if (!accountId) throw new Error('No Account Id Found.'); | ||
| return accountId; |
There was a problem hiding this comment.
Suggested change
| if (!accountId) throw new Error('No Account Id Found.'); | |
| return accountId; | |
| if (!accountId) { | |
| throw new Error('No Account Id Found.'); | |
| return accountId}; |
There was a problem hiding this comment.
How even this is possible to return Id after throwing error.
There was a problem hiding this comment.
Suggested change
| if (!accountId) throw new Error('No Account Id Found.'); | |
| return accountId; | |
| if (!accountId) { | |
| throw new Error('No Account Id Found.'); | |
| } | |
| return accountId; |
is what I meant
amir27111998
force-pushed
the
aws-account-id-optional
branch
from
5f9199b to
cdb3655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.