-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sulphate Rocks #5758
base: master
Are you sure you want to change the base?
Add Sulphate Rocks #5758
Conversation
We are currently in feature freeze until the next release. |
What is that part of the PR description about? If that's truly required then this has not chance to make it into 0.8.0. |
I was under the impression that the new category of chunk (sulfurMediumChunk) would require extra lines added for auto-evo and such to get it fully working. It's not that there's anything different about the implementation of these chunks. |
Oh yeah, that's probably true that a new miche needs to be added for eating the sulfur chunks... And that's already a problem with the small chunk as well. I opened a high priority issue for that: #5761 So yeah that specifically doesn't prevent merging this as the bug has already been added. |
Brief Description of What This PR Does
Adds new sulphate rocks as more floating sulfur chunks.
Replaces elemental sulfur chunks in some patches, and adds to them in others.
Adds Medium sulfur chunks.
Adds a small amount of H2S to Estuary patches, along with a small number of sulfur chunks.
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.