Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sulphate Rocks #5758

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Sulphate Rocks #5758

wants to merge 5 commits into from

Conversation

HexapodPhilosopher
Copy link
Contributor

@HexapodPhilosopher HexapodPhilosopher commented Dec 17, 2024

Brief Description of What This PR Does

Adds new sulphate rocks as more floating sulfur chunks.
Replaces elemental sulfur chunks in some patches, and adds to them in others.
Adds Medium sulfur chunks.
Adds a small amount of H2S to Estuary patches, along with a small number of sulfur chunks.

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

@hhyyrylainen hhyyrylainen requested review from buckly90 and a team December 17, 2024 06:47
@hhyyrylainen
Copy link
Member

Requires added code for AI handling, etc.

What is that part of the PR description about? If that's truly required then this has not chance to make it into 0.8.0.

@HexapodPhilosopher
Copy link
Contributor Author

HexapodPhilosopher commented Dec 17, 2024

I was under the impression that the new category of chunk (sulfurMediumChunk) would require extra lines added for auto-evo and such to get it fully working. It's not that there's anything different about the implementation of these chunks.

@hhyyrylainen
Copy link
Member

Oh yeah, that's probably true that a new miche needs to be added for eating the sulfur chunks... And that's already a problem with the small chunk as well. I opened a high priority issue for that: #5761

So yeah that specifically doesn't prevent merging this as the bug has already been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants