-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pilus hit effect utilizing cell burst effect #5247
base: master
Are you sure you want to change the base?
Conversation
The lead programmer for Thrive is currently on vacation until 2024-07-22. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed. PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged. |
Cell burst effect can be made more brighter but I'm waiting for others' opinion. |
When I hit another cell using my pilus, the hit effect is centered on my cell rather than the point of contact. Also, the effect is far too big and slow. A version of the effect with an instant start and fewer particles that disappear after a shorter distance would be better. |
I'll wait for visual tweaks on this before reviewing the code (as I think positioning logic being very different will warrant quite different technical implementation). Edit: I'll say that I haven't looked in game but if this just uses the cell burst effect as is, it is very unsuitable for a fast action that can happen often.
|
We are currently in feature freeze until the next release. |
Brief Description of What This PR Does
Related Issues
https://wiki.revolutionarygamesstudio.com/wiki/Release_Roadmap#0.6.x_(the_combat_and_part_upgrades_updates)
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.