Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce INP for ChainSelect dropdown #233

Merged
merged 18 commits into from
Oct 31, 2024
Merged

Conversation

Dozie2001
Copy link
Contributor

@Dozie2001 Dozie2001 commented Sep 22, 2024

This aims to solve #172

This PR reduces the individual INP on pages:

  • Landing Page
  • address/
  • exploits/[slug]
  • exploits/
  • learn/wallets/add-network/[network]

Copy link

vercel bot commented Sep 22, 2024

@Dozie2001 is attempting to deploy a commit to the Kalis Software Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

socket-security bot commented Sep 22, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@Dozie2001 Dozie2001 changed the title Injects theme script to fix theme issue Reduces INP Sep 22, 2024
@Dozie2001 Dozie2001 marked this pull request as ready for review October 1, 2024 10:09
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revoke-cash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 2:45pm

- Undo WIP changes to ChainLogo
- Memoize ChainLogo so it does not re-render for the same chain
- Use 'keepMounted' in ChainSelect so that it doesn't re-render options
- Undo most changes that add a lot of state and complexity
- Memoize ChainSelect(Href) and update its usage to match
@rkalis rkalis changed the title Reduces INP Reduce INP for ChainSelect dropdown Oct 31, 2024
@rkalis rkalis merged commit 89e47e9 into RevokeCash:master Oct 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants