feat: don't needlessly request logs + differentiate between eoa / uni…

…nitialized

lib/chains/events.ts

@@ -29,17 +29,25 @@ const getTokenEventsDefault = async (chainId: DocumentedChainId, address: Addres
   const publicClient = createViemPublicClientForChain(chainId);
   const logsProvider = getLogsProvider(chainId);
 
-  const [openSeaProxyAddress, fromBlock, toBlock, isLoggedIn] = await Promise.all([
+  const [openSeaProxyAddress, fromBlock, toBlock, nonce, isLoggedIn] = await Promise.all([
     getOpenSeaProxyAddress(address),
     0,
     publicClient.getBlockNumber().then((blockNumber) => Number(blockNumber)),
+    publicClient.getTransactionCount({ address }),
     apiLogin(),
   ]);
 
   if (!isLoggedIn) {
     throw new Error('Failed to create an API session');
   }
 
+  // If the address is an EOA and has no transactions, we can skip fetching events for efficiency. Note that all deployed contracts have a nonce of >= 1
+  // See https://eips.ethereum.org/EIPS/eip-161
+  if (nonce === 0) {
+    console.log('Skipping event fetching for EOA with no transactions', address);
+    return [];
+  }
+
   // Create required event filters
 
   const getErc721EventSelector = (eventName: 'Transfer' | 'Approval' | 'ApprovalForAll') => {

lib/utils/risk.tsx

@@ -10,6 +10,7 @@ export const RiskFactorScore: Record<string, number> = {
   exploit: 100,
   phishing_risk: 50,
   unsafe: 50,
+  uninitialized: 50,
 };
 
 export const filterUnknownRiskFactors = (riskFactors: RiskFactor[]): RiskFactor[] => {

lib/whois/spender/risk/OnchainSpenderRiskDataSource.ts

@@ -19,11 +19,15 @@ export class OnchainSpenderRiskDataSource implements SpenderDataSource {
 
     try {
       const time = new Date().getTime();
-      const bytecode = await publicClient.getCode({ address });
+      const [bytecode, nonce] = await Promise.all([
+        publicClient.getCode({ address }),
+        publicClient.getTransactionCount({ address }),
+      ]);
 
       const riskFactors = [];
 
-      if (this.isEOA(bytecode)) riskFactors.push({ type: 'eoa', source: 'onchain' });
+      if (this.isEOA(bytecode, nonce)) riskFactors.push({ type: 'eoa', source: 'onchain' });
+      if (this.isUninitialized(bytecode, nonce)) riskFactors.push({ type: 'uninitialized', source: 'onchain' });
       // if (this.isSmallBytecode(bytecode)) riskFactors.push({ type: 'unsafe', source: 'revoke' });
       if (this.isOpenSeaProxy(bytecode)) riskFactors.push({ type: 'deprecated', source: 'onchain' });
       if (this.hasPhishingRisk(address, bytecode)) riskFactors.push({ type: 'phishing_risk', source: 'onchain' });
@@ -41,11 +45,15 @@ export class OnchainSpenderRiskDataSource implements SpenderDataSource {
     }
   }
 
-  isEOA(bytecode?: Hex): boolean {
-    return isNullish(bytecode) || bytecode === '0x';
+  isEOA(bytecode: Hex | undefined, nonce: number): boolean {
+    return isNullish(bytecode) && nonce > 0;
   }
 
-  isSmallBytecode(bytecode: Hex): boolean {
+  isUninitialized(bytecode: Hex | undefined, nonce: number): boolean {
+    return isNullish(bytecode) && nonce === 0;
+  }
+
+  isSmallBytecode(bytecode?: Hex): boolean {
     return !isNullish(bytecode) && bytecode.length > 0 && bytecode.length < 1000;
   }
 

locales/en/address.json

@@ -88,6 +88,7 @@
     },
     "phishing_risk": "Increases risk surface in case of phishing",
     "source": "reported by <source-link>{source}</source-link>",
+    "uninitialized": "No contract deployed to this address",
     "unsafe": "Potentially unsafe contract code"
   },
   "search": {

locales/es/address.json

@@ -88,6 +88,7 @@
     },
     "phishing_risk": "Aumenta la superficie de riesgo en caso de phishing",
     "source": "reportado por <source-link>{source}</source-link>",
+    "uninitialized": "No contract deployed to this address",
     "unsafe": "Código de contrato potencialmente inseguro"
   },
   "search": {

locales/ja/address.json

@@ -88,6 +88,7 @@
     },
     "phishing_risk": "フィッシングの場合のリスク領域が増加",
     "source": "<source-link>{source}</source-link>に報告された",
+    "uninitialized": "No contract deployed to this address",
     "unsafe": "安全でない可能性のある契約コード"
   },
   "search": {

locales/ru/address.json

@@ -88,6 +88,7 @@
     },
     "phishing_risk": "Увеличивает поверхность риска в случае фишинга",
     "source": "сообщил(а)<source-link>{source}</source-link>",
+    "uninitialized": "No contract deployed to this address",
     "unsafe": "Потенциально небезопасный код контракта"
   },
   "search": {

locales/zh/address.json

@@ -88,6 +88,7 @@
     },
     "phishing_risk": "增加钓鱼风险",
     "source": "举报人：<source-link>{source}</source-link>",
+    "uninitialized": "No contract deployed to this address",
     "unsafe": "可能不安全的合约代码"
   },
   "search": {

package.json

@@ -14,7 +14,7 @@
     "lint:staged": "yarn lint --error-on-warnings --no-errors-on-unmatched --staged .",
     "lint:fix": "yarn lint --write",
     "postinstall": "husky install",
-    "translations:update": "localazy upload && localazy download && yarn lint",
+    "translations:update": "localazy upload && localazy download && yarn lint:fix",
     "translations:update:md": "localazy upload -k localazy.content.keys.json -c localazy.content.json && localazy download -k localazy.content.keys.json -c localazy.content.json && tsx scripts/remove-untranslated-markdown-files.ts",
     "test": "yarn test:mocha && yarn test:cypress",
     "test:cypress": "cypress run",