Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to work with latest OG-Core #12

Merged
merged 11 commits into from
Dec 5, 2023

Conversation

jdebacker
Copy link
Collaborator

This PR patches OG-MYS to work with the latest OG-Core release.

To do this, references to surv_rate are removed and rho is made into a 2-dimensional object.

Note: tests will not pass until OG-USA is updated via this PR.

@jdebacker jdebacker marked this pull request as draft October 24, 2023 00:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cfb084a) 80.35% compared to head (9bb37ea) 79.82%.

Files Patch % Lines
ogmys/demographics.py 80.00% 2 Missing ⚠️
ogmys/income.py 95.45% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   80.35%   79.82%   -0.53%     
==========================================
  Files           9       10       +1     
  Lines         682      570     -112     
==========================================
- Hits          548      455      -93     
+ Misses        134      115      -19     
Flag Coverage Δ
unittests 79.82% <93.87%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdebacker jdebacker marked this pull request as ready for review December 1, 2023 19:49
@jdebacker
Copy link
Collaborator Author

@rickecon This PR is ready for your review.

@rickecon
Copy link
Collaborator

rickecon commented Dec 5, 2023

Thanks @jdebacker. This PR looks great. Merging now.

@rickecon rickecon merged commit 8e0be88 into Revenue-Academy:main Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants