Sorts the ready panel further #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge conflict + I think you should get a handful of people to test this |
Swiftfeather
pushed a commit
that referenced
this pull request
Apr 29, 2024
…es (#27471) * MCR and Medicell * Extra define work * I know this could've been another PR but dear lord * there
ReturnToZender
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Update medical.dm * Automatic changelog for PR #1 [ci skip] * Delete html/changelogs/AutoChangeLog-pr-1.yml --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Useroth <[email protected]>
ReturnToZender
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Update medical.dm * Automatic changelog for PR #1 [ci skip] * Update kahraman_industries.dm * Delete html/changelogs/AutoChangeLog-pr-1.yml --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Useroth <[email protected]>
Majkl-J
pushed a commit
that referenced
this pull request
Jun 28, 2024
* Update medical.dm * Automatic changelog for PR #1 [ci skip] * Delete html/changelogs/AutoChangeLog-pr-1.yml * Update reagents.dm --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Useroth <[email protected]>
Swiftfeather
pushed a commit
that referenced
this pull request
Nov 25, 2024
…embeds on reagent spears (Bubberstation#2536) ## About The Pull Request This fixes two bugs. Quoting the player reported bug: Exploit #1 - Twitch Next Move modificier This one needs a bit of VV to test mostly to speed up the conditions, but its doable by a miner with a bit of skill. You need the berserker armor of the chosen one, or alternatively, the Dexterous mutation and a way to remove it (I think you can do so with mutadone, but never tried, regardless!) and Twitch. The short of it is that the next move variable is always edited with multiplicatives, but Twitch was coded with an aditive, so alternating one and another and then removing one effect and letting the other run out would net you with a lower than 1 next move variable. Exploit #2 - God Slaying Spear This one is easy to test, basically you all got a spear with better embeed stats than ninja stars, which embeeds most of the time thanks to its high embeed chance, plus its armor penetration, with no chance for it to fall out naturally so it has to be manually removed. Since it has a Bulky weight class, its damage multiplier is 4 plus the pain multiplier being 6, doing 24 damage per tick and on extraction, being able to kill a person that gets it in 10 seconds, even if armored. We had a whole clique abusing this as icecats on nova, and even combining it with morphine. https://github.com/Bubberstation/Bubberstation/blob/master/modular_skyrat/modules/reagent_forging/code/forge_weapons.dm#L136 ## Why It's Good For The Game Fixes some seriously game breaking bugs no one's abused yet, discovered on Nova, ## Proof Of Testing <details> <summary>Screenshots/Videos</summary> </details> ## Changelog :cl: OrbisAnima (code for 1), ReturnToZender (code for 2) fix: Fixes an exploit with Twitch, and the reagent forged spear's embedding. /:cl: --------- Co-authored-by: Arturlang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the sorted list from the crewmonitor to sort the estimation list.
Unsure if it works, and not sure how it interacts with silicons, as those aren't on the crew monitor's list.