Skip to content

Commit

Permalink
[MIRROR] Removes the ban on line splitting, adds a note about its pro…
Browse files Browse the repository at this point in the history
…per use (Skyrat-SS13#3709)

* Removes the ban on line splitting, adds a note about its proper use (#57112)

* Removes the ban on line splitting, adds a note about its proper use

Co-authored-by: LemonInTheDark <[email protected]>
  • Loading branch information
SkyratBot and LemonInTheDark authored Feb 28, 2021
1 parent b38eb2d commit 1953b7f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,8 @@ for (var/i in reagents)

* Do not divide when you can easily convert it to multiplication. (ie `4/2` should be done as `4*0.5`)

* Separating single lines into more readable blocks is not banned, however you should use it only where it makes new information more accessible, or aids maintainability. We do not have a column limit, and mass conversions will not be received well.

* If you used regex to replace code during development of your code, post the regex in your PR for the benefit of future developers and downstream users.

* Changes to the `/config` tree must be made in a way that allows for updating server deployments while preserving previous behaviour. This is due to the fact that the config tree is to be considered owned by the user and not necessarily updated alongside the remainder of the code. The code to preserve previous behaviour may be removed at some point in the future given the OK by maintainers.
Expand Down Expand Up @@ -666,7 +668,6 @@ Regarding sprites & sounds, you must credit the artist and possibly the codebase
## Banned content
Do not add any of the following in a Pull Request or risk getting the PR closed:
* National Socialist Party of Germany content, National Socialist Party of Germany related content, or National Socialist Party of Germany references
* Code where one line of code is split across mutiple lines (except for multiple, separate strings and comments; in those cases, existing longer lines must not be split up)
* Code adding, removing, or updating the availability of alien races/species/human mutants without prior approval. Pull requests attempting to add or remove features from said races/species/mutants require prior approval as well.
* Code which violates GitHub's [terms of service](https://github.com/site/terms).

Expand Down

0 comments on commit 1953b7f

Please sign in to comment.