Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #150

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

UI improvements #150

wants to merge 30 commits into from

Conversation

therealhoodboy
Copy link
Collaborator

No description provided.

@therealhoodboy therealhoodboy requested a review from Resaki1 May 16, 2024 17:16
@therealhoodboy
Copy link
Collaborator Author

Re-opened pull request, please share any opinion regarding the design changes

Copy link
Owner

@Resaki1 Resaki1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ideas, thanks! just some code styling issues

src/components/BuildMenu/BuildMenuEntry/BuildMenuEntry.tsx Outdated Show resolved Hide resolved
src/components/BuildMenu/BuildMenuEntry/BuildMenuEntry.tsx Outdated Show resolved Hide resolved
src/components/BuildMenu/BuildMenuEntry/BuildMenuEntry.tsx Outdated Show resolved Hide resolved
src/components/Foilage/foilage/TreeBirch.tsx Outdated Show resolved Hide resolved
src/components/Foilage/foilage/TreeBirch.tsx Outdated Show resolved Hide resolved
src/materials/materials.tsx Outdated Show resolved Hide resolved
Max Herter and others added 3 commits September 2, 2024 12:47
Copy link
Owner

@Resaki1 Resaki1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! Just some things to change

Also, on desktop the menus look kinda weird

Bildschirmfoto 2024-09-16 um 13 27 12

src/components/BuildMenu/BuildMenu.scss Outdated Show resolved Hide resolved
src/components/Map/Map.tsx Outdated Show resolved Hide resolved
src/components/RessourceMenu/RessourceMenu.scss Outdated Show resolved Hide resolved
Comment on lines -100 to +136
state.addRessources(BuildingSellBenefits[state.buildings[x][y]]);
const sellBenefits = BuildingSellBenefits[building];
const ressourcesToAdd = Object.fromEntries(
Object.entries(sellBenefits).map(([key, value]) => [key, value])
);
state.addRessources(ressourcesToAdd);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

src/store/store.ts Outdated Show resolved Hide resolved
src/store/store.ts Outdated Show resolved Hide resolved
src/store/store.ts Outdated Show resolved Hide resolved
src/store/store.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants