Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immersive Sounds full #69

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Immersive Sounds full #69

merged 3 commits into from
Nov 30, 2024

Conversation

CheBuRek017
Copy link

Добавляет возможность машинерии делать цикличные звуки + пак звуков с встроенным копирайтом.

Чейнджлог

🆑CheBuRek
wip: Фреймворк для звуков машинерии
soundadd: Звуки машинерии
/🆑
  • Pull Request полностью завершен, мне не нужна помощь чтобы его закончить.
  • Я внимательно прочитал все свои изменения и багов в них не нашел.
  • Я запускал сервер со своими изменениями локально и все протестировал.

800maximum123
800maximum123 requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@800maximum123 800maximum123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Измени документацию. Я, тем временем, запущу это у себя и проверю работу.
Если не будет проблем - пускаем.

mods/_fd/immersive_sounds/README.md Outdated Show resolved Hide resolved
@CheBuRek017
Copy link
Author

@800maximum123

800maximum123
800maximum123 approved these changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@800maximum123 800maximum123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ничего более критичного не вижу.
Good work!

@800maximum123 800maximum123 merged commit 26f2afc into RepoStash:Death-Of-Hope Nov 30, 2024
1 check passed
@800maximum123
Copy link
Collaborator

После запуска - перенесу на остальные бранчи

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@800maximum123 800maximum123 800maximum123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CheBuRek017 @800maximum123