Reolink api v7 #65
Reolink api v7 #65
Conversation
Just a print so the login failure reason is recorded
https://www.reddit.com/r/reolinkcam/comments/xpcxq6/ Now need the old password
These come disabled by default. The arg is 1 or 0, so we take a boolean and coerce it to integer, for the API's sake. Further we'll check the error code on the response
There was a problem hiding this comment.
Hey @Vaelatern
Thank you for the contribution! I just have some questions about the conversion from bool to int since the requests library should take care of this for you.
| if http_enable: | ||
| http_enable = 1 | ||
| else: | ||
| http_enable = 0 | ||
| if https_enable: | ||
| https_enable = 1 | ||
| else: | ||
| https_enable = 0 | ||
| if onvif_enable: | ||
| onvif_enable = 1 | ||
| else: | ||
| onvif_enable = 0 | ||
| if rtmp_enable: | ||
| rtmp_enable = 1 | ||
| else: | ||
| rtmp_enable = 0 | ||
| if rtsp_enable: | ||
| rtsp_enable = 1 | ||
| else: | ||
| rtsp_enable = 0 | ||
|
|
||
| body = [{"cmd": "SetNetPort", "action": 0, "param": {"NetPort": { | ||
| "httpEnable": http_enable, | ||
| "httpPort": http_port, | ||
| "httpsEnable": https_enable, | ||
| "httpsPort": https_port, | ||
| "mediaPort": media_port, | ||
| "onvifEnable": onvif_enable, | ||
| "onvifPort": onvif_port, | ||
| "rtmpEnable": rtmp_enable, | ||
| "rtmpPort": rtmp_port, | ||
| "rtspEnable": rtsp_enable, | ||
| "rtspPort": rtsp_port |
There was a problem hiding this comment.
We could rather use int() to convert the boolean instead of writing an if statement to map the boolean values to an integer.
~ ⟩ python3
Python 3.11.2 (main, Feb 7 2023, 13:52:42) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> print(int(True))
1
>>> print(int(False))
0
There was a problem hiding this comment.
probably don't even need to convert from bool to int so the variable can be passed along directly
| @@ -41,14 +41,14 @@ def set_osd(self, bg_color: bool = 0, channel: float = 0, osd_channel_enabled: b | |||
| body = [{"cmd": "SetOsd", "action": 1, | |||
| "param": { | |||
| "Osd": { | |||
| "bgcolor": bg_color, | |||
| "bgcolor": int(bg_color), | |||
There was a problem hiding this comment.
I'm not sure if one needs to convert bool explicitly here to int since requests will convert this for us when sending the request.
| "channel": channel, | ||
| "osdChannel": { | ||
| "enable": osd_channel_enabled, "name": osd_channel_name, | ||
| "enable": int(osd_channel_enabled), "name": osd_channel_name, |
| "osdTime": {"enable": int(osd_time_enabled), "pos": osd_time_pos}, | ||
| "watermark": int(osd_watermark_enabled), |
| @@ -51,7 +51,7 @@ def set_recording_encoding(self, | |||
| "action": 0, | |||
| "param": { | |||
| "Enc": { | |||
| "audio": audio, | |||
| "audio": int(audio), | |||
|
I think I did conversions to I forget. I'm happy to make those changes though. It's worth noting this doesn't support all of v7, just the parts I needed. If you think that's fine, I'm willing to apply the requested changes and see what happens. |
Yes, could you verify that there is indeed an error if you do not convert to Also please update the PR title using conventional commits as it is good practice and be more specific than |
|
I'm still going to update this Please note the PR title is disconnected from the commits, which are correctly named. The PR title you can edit to describe as you like. |
|
Yeah I tested and for some reason the bool didn't seem to convert to |
How did you test it? A simple cast in Python can convert a bool to an int. a = True
b = int(a)
print(b) |
I'll be slowly working on this as I need it. https://www.reddit.com/r/reolinkcam/comments/xpcxq6/reolink_camera_api_user_guide_v7_update_in_sept/
Please consider merging, or telling me what to improve so my work can be merged.
Have a great day!