Add SuccessfulResult static property #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyEspresso
approved these changes
Oct 31, 2023
Nihlus
requested changes
Nov 1, 2023
Remora.Results/Result.cs
Outdated
| /// The <see cref="Inner"/> property is also set to null. | ||
| /// </para> | ||
| /// </remarks> | ||
| public static IResult SuccessfulResult { get; } = FromSuccess(); |
There was a problem hiding this comment.
I'd shorten this to Success since it's a static property and it'll always be called with a reference to the Result type.
Consider adding a matching property to the typed result struct as well for symmetry.
There was a problem hiding this comment.
Shortened, added a matching property to the typed result aswell.
…prop, add props to ResultOfT
Nihlus
requested changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
SuccessfulResultstatic property toResultmuch likeValueTask's /Task'sCompletedTaskproperty with a cached boxed instance of a successful result.