Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/HIT-281-Change-of-field-names-applied-in-layouts-and-aggregations #49

Open
wants to merge 3 commits into
base: next-oort
Choose a base branch
from

Conversation

estelafs
Copy link

@estelafs estelafs commented May 24, 2024

Description

  • migration to add unique id to all fields/questions
  • on edit question unique id is now added to field, and question name is now editabel
  • records are updated with the new name
  • layouts fields, filters, sort and style rules are also updated
  • aggregations sourceFields and aggregations pipeline stages filter, sort, user, group, label and unwind are also updated

Useful links

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

See front-end PR

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs marked this pull request as ready for review June 5, 2024 21:11
@estelafs estelafs self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant