Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oort 229 #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Oort 229 #12

wants to merge 2 commits into from

Conversation

AntoineRelief
Copy link
Collaborator

Description

This PR implements two main changes:

  • On exporting records, the incremental id of each record is exported as well
  • On importing records, if an incremental id is provided (a valid one), the record with that id will be update instead of adding a new copy of the record

old pr

Type of change

Please delete options that are not relevant.

  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Export the record from a form/record. Notice that a column with the name IncrementalID should appear, followed by the incremental ID of each of the exported records
  • When uploading records, if a valid id is provided that record will be updated, if not (not provided or invalid) a new record will be added

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have put JSDoc comment in all required places
  • I have made corresponding changes to the documentation ( if required )
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have included screenshots describing my changes if relevant

@AntoineRelief AntoineRelief added the icebox On hold label Dec 11, 2023
@AntoineRelief
Copy link
Collaborator Author

@matheus-relief
any idea about if we should keep this one?
I just moved it from the other repo

@matheus-relief
Copy link
Collaborator

@AntoineRelief Oh yeah, I think it would be very useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox On hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants