Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OORT-239 - Add the possibility to set createdBy.user on excel import #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AntoineRelief
Copy link
Collaborator

Description

Add the possibility to set createdBy.user on excel import with a new $user column.
Improve error message for addUsers mutation when email is not correct.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with datasets for Guyane:
https://docs.google.com/spreadsheets/d/1T1jPrATTyBLqSBXQLcN2FuHL1TiOfrto/edit?usp=sharing&ouid=105162548979781419794&rtpof=true&sd=true
https://docs.google.com/spreadsheets/d/1WPtpBQB1hIe3HnyzUWltb7kEwdlAG7Y3/edit?usp=sharing&ouid=105162548979781419794&rtpof=true&sd=true

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have put JSDoc comment in all required places
  • I have made corresponding changes to the documentation ( if required )
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have included screenshots describing my changes if relevant

@AntoineRelief AntoineRelief added the icebox On hold label Dec 11, 2023
@AntoineRelief
Copy link
Collaborator Author

@matheus-relief
I moved the PR from the older
wasn't there already something done for that?
this one is a bit old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox On hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants