Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix same key for fetch with guests and news page #154

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions hooks/useArtistsGuests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,21 @@ import {
} from "../lib/contentful/pages/artists";
import { AllArtistEntry } from "../types/shared";

const fetcher = async (url) => {
const response = await fetch(url);
if (!response.ok) {
throw new Error("An error occurred while fetching the data.");
}
return await response.json();
};

export default function useArtistsGuests(fallbackData: AllArtistEntry[]) {
const { data, setSize, error, isValidating, isLoading } = useSWRInfinite(
(pageIndex) => [pageIndex * ARTISTS_GUESTS_PAGE_SIZE],
async (skip) => {
const r = await fetch(
`/api/artists?limit=${ARTISTS_GUESTS_PAGE_SIZE}&skip=${skip}&role=false`
);

return await r.json();
},
(pageIndex) =>
`/api/artists?limit=${ARTISTS_GUESTS_PAGE_SIZE}&skip=${
pageIndex * ARTISTS_GUESTS_PAGE_SIZE
}&role=false`,
fetcher,
{
fallbackData: [fallbackData],
revalidateFirstPage: false,
Expand Down
3 changes: 2 additions & 1 deletion hooks/useNewsArticles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
} from "../lib/contentful/pages/news";

export default function useNewsArticles(fallbackData: ArticleInterface[]) {
const { data, setSize } = useSWRInfinite(
const { data, setSize, isValidating } = useSWRInfinite(
(pageIndex) => [pageIndex * NEWS_ARTICLES_PAGE_SIZE],
async (skip) =>
getNewsPageArticles(false, NEWS_ARTICLES_PAGE_SIZE, skip[0]),
Expand All @@ -30,5 +30,6 @@ export default function useNewsArticles(fallbackData: ArticleInterface[]) {
articles,
loadMore,
isReachingEnd,
isValidating,
};
}
23 changes: 13 additions & 10 deletions hooks/useRadioShows.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,24 @@ import useSWRInfinite from "swr/infinite";
import { PastShowSchema } from "../types/shared";
import { RADIO_SHOWS_PAGE_SIZE } from "../lib/contentful/pages/radio";

const fetcher = async (url) => {
const response = await fetch(url);
if (!response.ok) {
throw new Error("An error occurred while fetching the data.");
}
return await response.json();
};

export default function useRadioShows(
fallbackData: PastShowSchema[],
filter: string[]
) {
const { data, setSize, error, isValidating, isLoading } = useSWRInfinite(
(pageIndex) => [pageIndex * RADIO_SHOWS_PAGE_SIZE, filter],
async (skip) => {
const r = await fetch(
`/api/shows?take=${RADIO_SHOWS_PAGE_SIZE}&skip=${skip}&filter=${encodeURIComponent(
filter.join(",")
)}`
);

return await r.json();
},
(pageIndex) =>
`/api/shows?take=${RADIO_SHOWS_PAGE_SIZE}&skip=${
pageIndex * RADIO_SHOWS_PAGE_SIZE
}&filter=${encodeURIComponent(filter.join(","))}`,
fetcher,
{
fallbackData: filter.length == 0 ? [fallbackData] : [],
revalidateFirstPage: false,
Expand Down
5 changes: 1 addition & 4 deletions lib/contentful/pages/artists.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,13 @@ import {
import { extractCollection, extractCollectionItem, sort } from "../../../util";
import { AllArtistFragment } from "../fragments";

export const ARTISTS_GUESTS_PAGE_SIZE = 500;
export const ARTISTS_GUESTS_PAGE_SIZE = 250;

export async function getArtistsPage(
role: boolean,
limit: number,
skip: number
) {
console.log("role", role);
console.log("limit", limit);
console.log("skip", skip);
const ArtistsPageQuery = /* GraphQL */ `
query ArtistsPageQuery($limit: Int, $skip: Int, $role: Boolean) {
artistCollection(
Expand Down
18 changes: 6 additions & 12 deletions views/news/allArticles.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import useNewsArticles from "../../hooks/useNewsArticles";
import { ArticleInterface } from "../../types/shared";
import Image from "next/image";
import { useState, useEffect } from "react";
import LoadMore from "../../components/loadMore";

export default function AllArticles({
articles: fallbackData,
}: {
articles: ArticleInterface[];
}) {
const { articles, loadMore, isReachingEnd } = useNewsArticles(fallbackData);
const { articles, loadMore, isReachingEnd, isValidating } =
useNewsArticles(fallbackData);

return (
<section>
Expand All @@ -26,21 +28,13 @@ export default function AllArticles({
<div className="flex justify-center mt-10 sm:mt-8">
<button
onClick={loadMore}
disabled={isValidating}
className="inline-flex focus:outline-none rounded-full items-center justify-center group"
aria-label="Load more shows"
>
<Image
src="/images/load-more-button.svg"
unoptimized
aria-hidden
width={128}
height={128}
priority
alt=""
/>

<LoadMore loading={isValidating} />
<span
className="absolute rounded-full h-20 w-20 group-focus:ring-4"
className="absolute rounded-full h-20 w-20 group-focus-visible:ring-4"
aria-hidden
/>
</button>
Expand Down
2 changes: 1 addition & 1 deletion views/radio/allShows.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default function AllShows({
))}
</ul>

{!isReachingEnd && (
{!isReachingEnd && !isLoading && (
<div className="flex justify-center mt-10 sm:mt-8">
<button
onClick={loadMore}
Expand Down
Loading