-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(time-picker): remove pre-populate value #995
Merged
wattachai-lseg
merged 12 commits into
v7
from
fix/remove-pre-populate-empty-segments-logic
Nov 9, 2023
Merged
fix(time-picker): remove pre-populate value #995
wattachai-lseg
merged 12 commits into
v7
from
fix/remove-pre-populate-empty-segments-logic
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: +135 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
Nantawat-Poothong
changed the title
fix(time-picker): remove pre populate value add new isolate update mode
fix(time-picker): remove pre populate value and add new update with keypress
Oct 25, 2023
Nantawat-Poothong
changed the title
fix(time-picker): remove pre populate value and add new update with keypress
fix(time-picker): remove pre populate value and add new update cycle for keyboard
Oct 26, 2023
Nantawat-Poothong
changed the title
fix(time-picker): remove pre populate value and add new update cycle for keyboard
fix(time-picker): remove pre-populate value and add new update cycle for keyboard
Oct 26, 2023
Nantawat-Poothong
changed the title
fix(time-picker): remove pre-populate value and add new update cycle for keyboard
fix(time-picker): remove pre-populate value
Oct 26, 2023
Sakchai-Refinitiv
requested changes
Oct 30, 2023
wsuwt
reviewed
Oct 30, 2023
Co-authored-by: Wasuwat Limsuparhat <[email protected]>
Sakchai-Refinitiv
previously approved these changes
Nov 2, 2023
wattachai-lseg
requested changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some additional issues to be addressed.
wsuwt
approved these changes
Nov 9, 2023
wattachai-lseg
approved these changes
Nov 9, 2023
wattachai-lseg
deleted the
fix/remove-pre-populate-empty-segments-logic
branch
November 9, 2023 08:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
time-picker behavior can pre-populate value of empty segments when focus between segment also update parent segment value when rolling through cycles.
These behaviors aren't align with native time input that could update segment value separately
Solution
Fixes # (issue)
https://jira.refinitiv.com/browse/ELF-2160
Checklist