fix(datetime-picker): change focus outline styles of calendar button #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(datetime-picker): refactor element
refactor(datetime-field): make resolveLocale function reusable refactor(datetime-picker): use ref instead of query fix(datetime-picker): when error value is entered, the value is reset on blur fix(datetime-picker): inputTriggerDisabled does not work fix(datetime-picker): cannot reset error value via API
feat(datetime-picker): add accessibility support feat(phrasebook): add datetime-picker strings
fix(datetime-picker): popup is not closed on all scenarios refactor(datetime-picker): simplify translation logic refactor(datetime-picker): simplify closing logic
… set an invalid view fix(datetime-picker): a warning is shown when a value with timepicker is set
fix(datetime-picker): seconds are not displayed
refactor(datetime-picker): improve code quality refactor(datetime-field): improve code quality
Deploying with
|
| Latest commit: |
dd0c2c1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe9b97ab.refinitiv-ui.pages.dev |
| Branch Preview URL: | https://fix-styles-focus-outline-of-.refinitiv-ui.pages.dev |
|
I do not think I like it :) |
|
Updated @goremikins
Calendar button focused
|
Base automatically changed from
feat/new-integrate-datetime-picker-with-datetime-field
to
feature/integrate-datetime-picker-with-datetime-field
August 19, 2022 14:27
added 3 commits
August 22, 2022 10:59
https://github.com/Refinitiv/refinitiv-ui into fix/styles-focus-outline-of-calendar-button
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change focus outline styles of calendar button
From
To
I use 2px outline width in Halo theme because with 1px it looks like a border more than an outline but I'm fine with 1px width as well.