-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added tile_picker feature for better dirt generation in diggy #894
base: develop
Are you sure you want to change the base?
Conversation
@@ -11,6 +11,7 @@ local ScoreTable = require 'map_gen.maps.diggy.score_table' | |||
local Command = require 'utils.command' | |||
local CreateParticles = require 'features.create_particles' | |||
local Ranks = require 'resources.ranks' | |||
local TilePicker = require 'map_gen.maps.diggy.feature.tile_picker' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you disable the feature, what happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It generates terrain like it used to if not enabled then return 'dirt-' .. random(1, 7) end
@linaori was wondering if i could get a final yes/no on this PR, so that we can clean out some of the old ones! |
I know this is an old PR but wanted to give some feedback. I like the option to use perlin noise for the floor tiles. Just a little sad that the changes create a new tile_picker.lua file to generate the terrain. Unfortunately, this moves a little further away from the wishlist item (Diggy feedback/todo collection thread #926) to try and use ore generation system (which is rather robust) and maybe expand it to be able to handle the noise for terrain and rooms (which also use noise) as well. Granted, the wishlist item came out shortly after this PR was made. |
Or even better, use when possible tools that are shared by other RedMew maps. Or add to shared tools if other maps could benefit. (I still need to learn a lot about what is exactly is available right now) |
Uses perlin noise for dirt generation so it is nicer to look at