Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old OSs [0.8] #558

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Remove old OSs [0.8] #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b8a546
disable old OSs
alonre24 Dec 1, 2024
5c2b06c
format
alonre24 Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions .github/workflows/event-merge-to-queue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Merge a Pull-Request Flow
run-name: Validate ${{ github.ref_name }}

on:
workflow_dispatch:
workflow_call:
merge_group:
types: [checks_requested]
Expand All @@ -22,22 +23,22 @@ jobs:
uses: ./.github/workflows/task-unit-test.yml
with:
container: ubuntu:focal
bionic:
needs: [check-if-docs-only]
if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
uses: ./.github/workflows/task-unit-test.yml
with:
container: ubuntu:bionic
# bionic:
# needs: [check-if-docs-only]
# if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
# uses: ./.github/workflows/task-unit-test.yml
# with:
# container: ubuntu:bionic
bullseye:
needs: [check-if-docs-only]
if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
uses: ./.github/workflows/task-unit-test.yml
with:
container: debian:bullseye
amazonlinux2:
needs: [check-if-docs-only]
if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
uses: ./.github/workflows/amazon2.yml
# amazonlinux2:
# needs: [check-if-docs-only]
# if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
# uses: ./.github/workflows/amazon2.yml
mariner2:
needs: [check-if-docs-only]
if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
Expand Down Expand Up @@ -75,9 +76,9 @@ jobs:
- check-if-docs-only
- jammy
- focal
- bionic
# - bionic
- bullseye
- amazonlinux2
# - amazonlinux2
- mariner2
- rocky8
- rocky9
Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/event-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: nightly

on:
workflow_dispatch:
schedule:
- cron: '0 20 * * *'

Expand All @@ -21,18 +22,18 @@ jobs:
with:
container: ubuntu:focal
run-valgrind: false
bionic:
uses: ./.github/workflows/task-unit-test.yml
with:
container: ubuntu:bionic
run-valgrind: false
# bionic:
# uses: ./.github/workflows/task-unit-test.yml
# with:
# container: ubuntu:bionic
# run-valgrind: false
bullseye:
uses: ./.github/workflows/task-unit-test.yml
with:
container: debian:bullseye
run-valgrind: false
amazonlinux2:
uses: ./.github/workflows/amazon2.yml
# amazonlinux2:
# uses: ./.github/workflows/amazon2.yml
mariner2:
uses: ./.github/workflows/mariner2.yml
rocky8:
Expand Down
2 changes: 1 addition & 1 deletion src/VecSim/algorithms/hnsw/graph_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ struct ElementLevelData {
idType links[];

explicit ElementLevelData(std::shared_ptr<VecSimAllocator> allocator)
: incomingUnidirectionalEdges(new(allocator) vecsim_stl::vector<idType>(allocator)),
: incomingUnidirectionalEdges(new (allocator) vecsim_stl::vector<idType>(allocator)),
numLinks(0) {}

linkListSize getNumLinks() const { return this->numLinks; }
Expand Down
6 changes: 3 additions & 3 deletions src/python_bindings/bindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ py::object wrap_results(VecSimQueryReply **res, size_t num_res, size_t num_queri
VecSimQueryReply_Free(res[i]);
}

py::capsule free_when_done_l(data_numpy_l, [](void *labels) { delete[] (long *)labels; });
py::capsule free_when_done_d(data_numpy_d, [](void *dists) { delete[] (double *)dists; });
py::capsule free_when_done_l(data_numpy_l, [](void *labels) { delete[](long *) labels; });
py::capsule free_when_done_d(data_numpy_d, [](void *dists) { delete[](double *) dists; });
return py::make_tuple(
py::array_t<long>(
{(size_t)num_queries, num_res}, // shape
Expand Down Expand Up @@ -132,7 +132,7 @@ class PyVecSimIndex {
}

py::capsule free_when_done(data_numpy,
[](void *vector_data) { delete[] (NPArrayType *)vector_data; });
[](void *vector_data) { delete[](NPArrayType *) vector_data; });
return py::array_t<NPArrayType>(
{n_vectors, dim}, // shape
{dim * sizeof(NPArrayType),
Expand Down
12 changes: 6 additions & 6 deletions tests/module/redismodule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,10 +855,10 @@ RedisModuleString *(*RedisModule_HoldString)(RedisModuleCtx *ctx,
REDISMODULE_API int (*RedisModule_StringCompare)(RedisModuleString *a,
RedisModuleString *b) REDISMODULE_ATTR;
REDISMODULE_API RedisModuleCtx *(*RedisModule_GetContextFromIO)(RedisModuleIO *io)REDISMODULE_ATTR;
REDISMODULE_API const RedisModuleString *(*RedisModule_GetKeyNameFromIO)(RedisModuleIO *io)
REDISMODULE_ATTR;
REDISMODULE_API const RedisModuleString *(*RedisModule_GetKeyNameFromModuleKey)(RedisModuleKey *key)
REDISMODULE_ATTR;
REDISMODULE_API const
RedisModuleString *(*RedisModule_GetKeyNameFromIO)(RedisModuleIO *io)REDISMODULE_ATTR;
REDISMODULE_API const
RedisModuleString *(*RedisModule_GetKeyNameFromModuleKey)(RedisModuleKey *key)REDISMODULE_ATTR;
REDISMODULE_API int (*RedisModule_GetDbIdFromModuleKey)(RedisModuleKey *key) REDISMODULE_ATTR;
REDISMODULE_API int (*RedisModule_GetDbIdFromIO)(RedisModuleIO *io) REDISMODULE_ATTR;
REDISMODULE_API int (*RedisModule_GetDbIdFromOptCtx)(RedisModuleKeyOptCtx *ctx) REDISMODULE_ATTR;
Expand All @@ -874,8 +874,8 @@ REDISMODULE_API void (*RedisModule_DigestAddLongLong)(RedisModuleDigest *md,
long long ele) REDISMODULE_ATTR;
REDISMODULE_API void (*RedisModule_DigestEndSequence)(RedisModuleDigest *md) REDISMODULE_ATTR;
REDISMODULE_API int (*RedisModule_GetDbIdFromDigest)(RedisModuleDigest *dig) REDISMODULE_ATTR;
REDISMODULE_API const RedisModuleString *(*RedisModule_GetKeyNameFromDigest)(RedisModuleDigest *dig)
REDISMODULE_ATTR;
REDISMODULE_API const
RedisModuleString *(*RedisModule_GetKeyNameFromDigest)(RedisModuleDigest *dig)REDISMODULE_ATTR;
REDISMODULE_API RedisModuleDict *(*RedisModule_CreateDict)(RedisModuleCtx *ctx)REDISMODULE_ATTR;
REDISMODULE_API void (*RedisModule_FreeDict)(RedisModuleCtx *ctx,
RedisModuleDict *d) REDISMODULE_ATTR;
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_hnsw_parallel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include <atomic>

// Helper macro to get the closest even number which is equal or lower than x.
#define FLOOR_EVEN(x) ((x) - ((x) & 1))
#define FLOOR_EVEN(x) ((x) - ((x)&1))

template <typename index_type_t>
class HNSWTestParallel : public ::testing::Test {
Expand Down
Loading