Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize properly repair/insert test #555

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

alonre24
Copy link
Collaborator

@alonre24 alonre24 commented Nov 7, 2024

Describe the changes in the pull request

Completion for #546 where we added the index guard mechanism to make parallel insertion into HNSW thread safe with respect to data blocks resize that requires exclusive lock.

Here we add the missing protection to the repair operation with mutual lock while insertion is running.
Also, setting a lower block size in the test to better expose the failure, and apply the common synchronization logic to another parallel test.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (1381f64) to head (4ace1e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files         100      100           
  Lines        5287     5287           
=======================================
  Hits         5125     5125           
  Misses        162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonre24 alonre24 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 1b8a846 Nov 12, 2024
16 checks passed
@alonre24 alonre24 deleted the fix_parallel_hnsw_test branch November 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants