Synchronize properly repair/insert test #555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Completion for #546 where we added the index guard mechanism to make parallel insertion into HNSW thread safe with respect to data blocks resize that requires exclusive lock.
Here we add the missing protection to the repair operation with mutual lock while insertion is running.
Also, setting a lower block size in the test to better expose the failure, and apply the common synchronization logic to another parallel test.
Mark if applicable