Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action to automatically run eslint --fix on PRs and commit the changes #35

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

Narinder788
Copy link
Contributor

Summary

What is the nature of this pull request?

  • Configuration update

Description of change

This pull request updates the GitHub Actions workflow to automatically run eslint --fix on pull requests. If any linting errors are fixed, the changes will be committed back to the branch automatically.

Changes made:

  • Added a step to run npx eslint . --fix to automatically fix linting errors during the pull request workflow.
  • Added a step to commit and push the changes if any fixes are applied by ESLint.

Planner card link

GitHub action to automatically run eslint --fix on PRs and commit the changes

@Narinder788 Narinder788 requested review from doubleedesign and a team as code owners October 5, 2024 08:46
@doubleedesign
Copy link
Contributor

Well done @Narinder788, thanks for this! The change makes enough sense to me that I'm going to assume the check isn't running on this PR is because it's the one you edited, and it will work on future PRs (if not, we can roll back).

@doubleedesign doubleedesign merged commit 88dfb15 into Redback-Operations:main Oct 6, 2024
@doubleedesign
Copy link
Contributor

Sorry @Narinder788, have to roll it back because of this:

image

doubleedesign added a commit that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants