Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number/value picker component #19

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Number/value picker component #19

merged 3 commits into from
Sep 16, 2024

Conversation

doubleedesign
Copy link
Contributor

Summary

What is the nature of this pull request?

  • New feature
  • Enhancement to an existing feature
  • Bug fix
  • Configuration update
  • Dependency update

Description of change

This PR adds a drop-down component using React Select which adopts the current theme and accepts an onChange function that will provide the selected value back to the calling component for use.

I have manually tested the component using both mouse and keyboard interaction, and adjusted styling accordingly. I have also included extensive unit tests which cover this too.

Planner card link

Redback UI - number/value picker component

Readiness

  • The application runs successfully with my change.
  • I have included code comments where appropriate.
  • Where I have copied and pasted code from other sources, I have included a comment with a link to the original source.
  • I have read and followed the principles and guidelines about submitting code.
  • I have added unit tests for new components and/or functionality.
  • All existing and new unit tests pass (including updating tests for any necessary breaking changes).

@doubleedesign doubleedesign requested a review from a team as a code owner September 1, 2024 11:12
@doubleedesign doubleedesign merged commit 5edeb7e into main Sep 16, 2024
1 check passed
@doubleedesign doubleedesign deleted the value-picker-component branch September 16, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant