Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page header component #16

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Page header component #16

wants to merge 19 commits into from

Conversation

Narinder788
Copy link
Contributor

No description provided.

@Narinder788 Narinder788 requested review from doubleedesign and a team as code owners August 23, 2024 22:22
doubleedesign
doubleedesign suggested changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@doubleedesign doubleedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good start! Just needs some tweaks to use theme colours and to ensure the Storybook demo showcases the component properly. Well done!

src/components/PageHeader/PageHeader.stories.ts Show resolved Hide resolved
src/components/PageHeader/PageHeader.style.ts Outdated Show resolved Hide resolved
src/components/PageHeader/PageHeader.style.ts Outdated Show resolved Hide resolved
@Narinder788
Copy link
Contributor Author

Narinder788 commented Sep 17, 2024 •
edited
Loading

Thank you, I resolved all the merge conflicts and will make a ticket for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doubleedesign doubleedesign doubleedesign requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Narinder788 @doubleedesign @ben-AI-cybersec