Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal component #15

Merged
merged 13 commits into from
Sep 2, 2024
Merged

Modal component #15

merged 13 commits into from
Sep 2, 2024

Conversation

Narinder788
Copy link
Contributor

No description provided.

@Narinder788 Narinder788 requested review from doubleedesign and a team as code owners August 23, 2024 20:46
doubleedesign
doubleedesign suggested changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@doubleedesign doubleedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start for your first contribution! It just really needs the ability to close the modal to be ready for use.

src/components/Modal/Modal.tsx Outdated Show resolved Hide resolved
src/components/Modal/Modal.test.tsx Outdated Show resolved Hide resolved
src/components/Modal/Modal.tsx Show resolved Hide resolved
@doubleedesign
Copy link
Contributor

Well done!

@doubleedesign doubleedesign merged commit b77c806 into Redback-Operations:main Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doubleedesign doubleedesign doubleedesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Narinder788 @doubleedesign