Project 2(elderly wearable webpage) #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doubleedesign
suggested changes
May 13, 2024
There was a problem hiding this comment.
- Please refactor to work with React.
- All code needs to be in the existing React app in the
srcfolder. Please do not add a new React app or any other new folders other than those required to create your routes and components.
Please see the guides on the company documentation website for more information.
doubleedesign
suggested changes
May 14, 2024
| import healthMonitoringImage from './healthmonitoring.jpeg'; // Import images | ||
| import medicationReminderImage from './medication reminder.jpeg'; | ||
|
|
||
| class ExploreFeatures extends React.Component { |
There was a problem hiding this comment.
Please use function components, as class components are deprecated. Here's some more information including how to migrate.
src/html/contact.html
Outdated
| @@ -0,0 +1,20 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Please refactor all HTML in to React components. There should not be any new .html files.
| @@ -0,0 +1,333 @@ | |||
| /* External CSS style file */ | |||
There was a problem hiding this comment.
Please refactor all CSS into Styled Components. You can find some more information here: https://redback-operations.github.io/redback-documentation/docs/web-mobile-app-dev/frontend/styled-components
|
Tested locally. None of this code appears to work with the react app. Closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.