Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Project 5: Privacy Policy + Terms & Conditions Added, Names of Robots Updated + Additional Robots #204

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

jessmoogs
Copy link
Contributor

Update to Project 5: Privacy Policy + Terms & Conditions Added, Names of Robots Updated + Additional Robots

@jessmoogs jessmoogs requested review from a team as code owners December 13, 2024 06:05
@AmirZandiehprojects
Copy link
Collaborator

Hi @jessmoogs,

Nice work on the robot characters and documentation! A few quick points:

  1. Image paths need fixing:

    • Change backslashes to forward slashes in all image references
    • Example: img\blue-robot.PNG should be img/blue-robot.PNG
  2. The robot descriptions look great! The new additions (Squeak, Chopper, and Grumpy) fit well with the existing characters and have good personality descriptions.

  3. Documentation structure is good:

    • Proper sidebar positions
    • Info blocks are formatted correctly
    • Everything is well organized

Just fix those image paths and it should be good to go!

Let me know if you need any help with the changes.

@jessmoogs jessmoogs closed this Dec 15, 2024
@jessmoogs jessmoogs reopened this Dec 15, 2024
@AmirZandiehprojects AmirZandiehprojects merged commit c0d782a into Redback-Operations:main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants