🐛 Refresh affect trackers after filing trackers #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMarble
reviewed
Nov 6, 2024
| @@ -239,3 +240,15 @@ function flawErrors(flaw: ZodFlawType) { | |||
|
|
|||
| return mirroredFlaw; | |||
| } | |||
|
|
|||
| export async function refreshFlawAffectTrackers(flaw: Ref<ZodFlawType>) { | |||
| const freshFlaw = await getFlaw(flaw.value.uuid); | |||
There was a problem hiding this comment.
Should we add some kind of loader to this action?
There was a problem hiding this comment.
Also, now that the trackers are handled asynchronous, I'm not sure about UX, we are realoading things but it may occur that nothing changes, users are already aware of that, but it can be confusing
There was a problem hiding this comment.
Hrm, maybe we should the delay should be long just to grab the flaw, but that might be best to trigger a loading state
superbuggy
force-pushed
the
feature/OSIDB-3483-fix-tracker-refresh-after-filing
branch
from
e8c74c2 to
357dad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[OSIDB-ID] [Title]
Checklist:
Summary:
[Replace with a brief summary of the changes introduced by this PR.]
Changes:
[Replace with a detailed description of the changes made in this PR, including any new features, enhancements, bug fixes, or refactorings.]
Considerations:
[Replace with any additional considerations, notes, or instructions for reviewers.]
Closes OSIDB-3483