Change Audit models ACLs on Flaw unembargo #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbuggy
force-pushed
the
feature/OSIDB-3463-reset-flaw-audit-acls-on-unembargo
branch
2 times, most recently
from
82bf250 to
1cfd63a
Compare
MrMarble
reviewed
Dec 11, 2024
Comment on lines
+540
to
+541
| db, model_name = ref.pgh_model.split(".") | ||
| model_audit = apps.get_model(db, model_name).objects.filter( |
There was a problem hiding this comment.
There's no need to split the name, you can pass it directly
Suggested change
| db, model_name = ref.pgh_model.split(".") | |
| model_audit = apps.get_model(db, model_name).objects.filter( | |
| model_audit = apps.get_model(ref.pgh_model).objects.filter( |
osoukup
requested changes
Dec 13, 2024
|
|
||
| ```sh | ||
| $ podman logs -f osidb-service | ||
| ``` |
There was a problem hiding this comment.
I am not strongly against this but I wonder whether documenting Podman is not beyond OSIDB documentation. There are certainly tons of potentially useful Podman commands but it has its own documentation. If it was some specific OSIDB procedure, it was non-intuitive, etc. then probably let us document it here.
Make linting corrections Update secrets Make more linting corrections
superbuggy
force-pushed
the
feature/OSIDB-3463-reset-flaw-audit-acls-on-unembargo
branch
from
8672b33 to
1c3bc36
Compare
osoukup
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OSIDB-3463