Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(create): replaces implementation for component definition cr… #56

Merged
merged 7 commits into from
Oct 26, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Oct 23, 2023

What's Changed?

Removes scripts and trestlebot install
Adds reference to published trestlebot image in create-new.yml
Update create-new.yml steps

Blocked by RedHatProductSecurity/trestle-bot#68

How to Test

  • Copy changes from jpower432/PSCE-259 branch
  • Run Component Definitions Create workflow on that branch
  • Fill in required fields - filter-by-profile is the only optional field
  • Start the workflow

https://github.com/jpower432/oscal-component-definitions/actions/runs/6630470740
jpower432#6
With filtering - jpower432@358a4dd

…eation

Removes scripts and trestlebot install
Adds reference to published trestlebot image in create-new.yml

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review October 24, 2023 20:05
@jpower432 jpower432 requested a review from a team as a code owner October 24, 2023 20:05
Copy link

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired code review on October 26

@jpower432 jpower432 merged commit e64b135 into RedHatProductSecurity:main Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants