Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

fix regex escaping #288

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix regex escaping #288

merged 2 commits into from
Jan 22, 2024

Conversation

JimFuller-RedHat
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat commented Jan 22, 2024

fixed escaping when -r option is used - removed any special escaping which turns out to not be required.

Note - added to smoke tests

@JimFuller-RedHat JimFuller-RedHat self-assigned this Jan 22, 2024
@JimFuller-RedHat JimFuller-RedHat marked this pull request as draft January 22, 2024 09:38
@JimFuller-RedHat JimFuller-RedHat changed the title fix smoke tests fix regex escaping and smoke tests Jan 22, 2024
@JimFuller-RedHat JimFuller-RedHat changed the title fix regex escaping and smoke tests fix regex escaping Jan 22, 2024
@JimFuller-RedHat JimFuller-RedHat marked this pull request as ready for review January 22, 2024 10:49
@JimFuller-RedHat JimFuller-RedHat force-pushed the fix-smoke-tests branch 2 times, most recently from 0cd4d7f to 443030f Compare January 22, 2024 11:11
Copy link
Collaborator

@JakubFrejlach JakubFrejlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes a regression, I believe you probably meant to delete the regex escaping only in the output module

griffon/services/core_queries.py Show resolved Hide resolved
Copy link
Collaborator

@JakubFrejlach JakubFrejlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good job!

@JimFuller-RedHat JimFuller-RedHat merged commit a6fb248 into main Jan 22, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants