GRIF-130: Fix middleware CLI usage #274

JakubFrejlach · 2023-12-08T12:29:25Z

This PR:

fixes the filtering of middleware CLI data
standardize data (even upstreams and sources related data) to JSON in output module

In __ini__.py zsh/bash autocompletion eval has problems with the direct print statements and tries to evaluate the text which is printed

Leftover from OSIDB/CORGI API to SERVER change

This is for users who doesn't use single command but run middleware cli through python. Python subprocess requires all parts of the command to be separated

Check for mutually exclusive groups or one of groups should only run when griffon itself is running. During tab completion these checks should be disabled.

* consider all middleware data retrieved by middleware CLI active * delegate maven build type filter to middleware CLI

sources and upstreams are transformed to raw JSON now so we avoid problems when mixing middleware CLI data and component registry data (eg. Component registry bindings models vs JSON)

JimFuller-RedHat

LGTM

JakubFrejlach requested a review from JimFuller-RedHat December 8, 2023 12:29

JakubFrejlach self-assigned this Dec 8, 2023

JakubFrejlach added 6 commits December 8, 2023 13:29

Move envvar checks from __init__.py to CLI

08e2c5d

In __ini__.py zsh/bash autocompletion eval has problems with the direct print statements and tries to evaluate the text which is printed

Change community corgi env var URL from API to server

cdaa6c3

Leftover from OSIDB/CORGI API to SERVER change

Update changelog

5f97444

Split MIDDLEWARE_CLI command on spaces

d4c4450

This is for users who doesn't use single command but run middleware cli through python. Python subprocess requires all parts of the command to be separated

Fix custom command check on tab completion

50794d3

Check for mutually exclusive groups or one of groups should only run when griffon itself is running. During tab completion these checks should be disabled.

Fix filtering middleware data

fa14c84

* consider all middleware data retrieved by middleware CLI active * delegate maven build type filter to middleware CLI

JakubFrejlach force-pushed the fix-depcli-usage branch from 85aa03e to 44f6cc9 Compare December 8, 2023 12:29

JakubFrejlach added 2 commits December 8, 2023 14:10

Standardize work with related data

7a9f1b8

sources and upstreams are transformed to raw JSON now so we avoid problems when mixing middleware CLI data and component registry data (eg. Component registry bindings models vs JSON)

Update changelog

a386820

JakubFrejlach force-pushed the fix-depcli-usage branch from 44f6cc9 to a386820 Compare December 8, 2023 13:11

JimFuller-RedHat approved these changes Dec 8, 2023

View reviewed changes

JakubFrejlach merged commit 69fbe3f into main Dec 13, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GRIF-130: Fix middleware CLI usage #274

GRIF-130: Fix middleware CLI usage #274

JakubFrejlach commented Dec 8, 2023

JimFuller-RedHat left a comment

GRIF-130: Fix middleware CLI usage #274

GRIF-130: Fix middleware CLI usage #274

Conversation

JakubFrejlach commented Dec 8, 2023

JimFuller-RedHat left a comment

Choose a reason for hiding this comment