This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Various improvements #270
Merged
Various improvements #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused a lot of confusion whether to assign OSIDB/Corgi API URL or more generally server URL. Since Griffon only needs general url name of these variables were changed
This helper is supposed to format text color/style in cases where rich cannot be used (exceptions for example)
this also fixes non working no progress bar option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this PR aimed for the GRIF-118 and a lot of additional improvements were done while working on this, however GRIF-118 was recently proclaimed as obsolete due to a change of process and thus this PR brings only the improvements and not the actual GRIF-118 implementation.
Changes:
no_progress_barwas fixed