Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

GRIF-193: OSIDB 3.5.0 entities #265

Merged
merged 3 commits into from
Oct 17, 2023
Merged

GRIF-193: OSIDB 3.5.0 entities #265

merged 3 commits into from
Oct 17, 2023

Conversation

JakubFrejlach
Copy link
Collaborator

This PR:

  • adds support for OSIDB 3.5.0 entities (Flaw CVSS, Flaw Package Versions, Affect CVSS)
  • refactors OSIDB entities module into several smaller modules (1 module per 1 entity) for better navigation

Flaw CVSS (CVSS scores), Flaw Package Versions, Affect CVSS (CVSS scores)
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (was a bit involved due to the restructure) ... starting to wonder for update scenarios if we want to consider some kind of minimal mocking

@JakubFrejlach
Copy link
Collaborator Author

LGTM (was a bit involved due to the restructure) ... starting to wonder for update scenarios if we want to consider some kind of minimal mocking

Can you elaborate a little bit please?

@JimFuller-RedHat
Copy link
Collaborator

re mocking - the decision to not do mocking on reads was based on the fact that we test extensively in the services themselves ... mutation has less coverage and just 'out loud thinking' if we should consider mock tests for update scenarios ... just a random observation unrelated to this PR.

@JakubFrejlach JakubFrejlach merged commit 5353a02 into main Oct 17, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants