Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From cvss40 to cvss4 for future usage #64

Closed
wants to merge 5 commits into from

Conversation

n3rada
Copy link
Contributor

@n3rada n3rada commented Sep 6, 2024

This is my final pull request, following our recent discussion. To maintain a more coherent naming convention—considering the repository is named cvss-v4-calculator and @nickleali mentioned v4.1—it seems more appropriate to have a file named cvss4.js. This way, we can extend classes for specific versions in the future.

What do you think about this approach?

@superbuggy
Copy link
Collaborator

I'm fine with the class name change, but would prefer the 4.0 to be kept in comments and in the UI for the sake of accuracy. What is the reason for the change? I didn't understand that this change would be entailed from the discussion #63

@n3rada
Copy link
Contributor Author

n3rada commented Sep 9, 2024

Good for you?

@pandatix
Copy link
Contributor

Let's dive in the history of CVSS. In v3.0 there were maths, and in v3.1 they changed a bit.
With the current strategy, moving from CVSS40 to CVSS4 would require us to later rollback to support a new iteration. Or am I wrong ?

It is not planned to change maths yet, but I don't think it is required to move from CVSS40 to CVSS4 neither.

@skontar
Copy link
Collaborator

skontar commented Sep 12, 2024

I think it was "4" before and then "4.0" later and then there was some discussion about potentially having 4.1 in the future. To be honest, I have preference to leave things as is at the moment and close this PR. We can always change and rename things later if needed and when needed.

@n3rada
Copy link
Contributor Author

n3rada commented Sep 12, 2024

Agreed, @skontar. My initial idea was to keep this repository up and running for any upcoming versions, in order to be prepared for CVSS 4.x. I'll close it! Thanks to all of you for always being professional.

@n3rada n3rada closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants