test: add missing unit test #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-X64
approved these changes
May 23, 2024
notify/metricslog_test.go
Outdated
| }{ | ||
| { | ||
| name: "Remove 3 oldest samples", | ||
| log: &MetricsLog{path: "/tmp/test_log"}, |
There was a problem hiding this comment.
As all of these tests are executed in sequence this will work just fine.
If you want to ensure that the same tmp file isn't used in other tests that might lead to flanky test results you can use ioutils.tempFile
There was a problem hiding this comment.
For this usecase it might be good to use t.TempDir https://pkg.go.dev/testing#B.TempDir as it is used e.g. in function createMetricsPath - or use this function.
There was a problem hiding this comment.
Thanks for the feedback. I think that's a good suggestion for this usecase tried updating the code, it's a little cleaner now too!
ConorC117
force-pushed
the
tests
branch
2 times, most recently
from
b03c4cc to
af4802e
Compare
Add table-driven unit test for removeOldestSample function Signed-off-by: ccowman <[email protected]>
F-X64
approved these changes
May 27, 2024
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add table-driven unit test for removeOldestSample function