Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update github actions to use node.js 20 #47

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

ConorC117
Copy link
Collaborator

@ConorC117 ConorC117 commented Apr 10, 2024

Update deprecated Node.js 16 actions in commitlint.yml and go.yml to use Node.js 20.

https://issues.redhat.com/browse/CLOUDX-889

Updates the following actions:
checkout@v3 --> checkout@v4
setup-node@v3 --> setup-node@v4
setup-go@v4 --> setup-go@v5
upload-artifact@v3 --> upload-artifact@v4

NOTE:
As of upload-artifact@v4, it's no longer possible to upload multiple same-named artifacts (see the second breaking change here, so I split the "go-coverage" artifact in go.yml into two separately named artifacts. Any feedback on this approach is appreciated!

@ConorC117 ConorC117 self-assigned this Apr 10, 2024
@ConorC117 ConorC117 closed this Apr 10, 2024
@ConorC117 ConorC117 reopened this Apr 10, 2024
Update deprecated Node.js 16 actions in commitlint.yml and go.yml
to use Node.js 20.

Signed-off-by: ccowman <[email protected]>
@ConorC117 ConorC117 marked this pull request as ready for review April 10, 2024 13:49
@ConorC117 ConorC117 requested review from major, F-X64 and miyunari April 10, 2024 13:50
Copy link
Collaborator

@F-X64 F-X64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged.

@ConorC117 ConorC117 merged commit 81151bf into RedHatInsights:main Apr 10, 2024
7 checks passed
@ConorC117 ConorC117 deleted the workflows branch May 3, 2024 10:53
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants