feat: add optional InstanceID field to log output #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-X64
requested changes
Apr 10, 2024
| @@ -51,7 +51,7 @@ func TestInitLogger(t *testing.T) { | |||
| func TestInitLoggerFile(t *testing.T) { | |||
| dir := t.TempDir() | |||
| path := dir + "/test.log" | |||
| InitLogger(path, DebugLevel.String()) | |||
| InitLogger(path, DebugLevel.String(), "test_instance") | |||
There was a problem hiding this comment.
Currently we only test whether the logger is correctly initialized.
Consider adding a test for the prefix as well, e.g.
if !strings.HasPrefix(string(data), "[test_instance]") {
t.Errorf("Expected the output to start with '[test_instance]', but got: %s", string(data))
}
There was a problem hiding this comment.
Thanks for the feedback and for testing the code. Will make the change!
Add an optional instanceID field to log output for distinguishing multiple running host-metering instances from each other during development. Signed-off-by: ccowman <[email protected]>
F-X64
approved these changes
Apr 10, 2024
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional instanceID field to log output for distinguishing multiple running host-metering instances from each other during development.
Example implementation of adding an optional, custom instanceID to log output for distinguishing multiple running host-metering instances from each other during development.
The instanceID value is an empty string by default and only added to the log output if the string is populated in the config file.
Any feedback on my approach or suggestions for improvements is appreciated!